Discussion on Updating DataHub_GMS_PORT Variable and Docker Health Checks

Original Slack Thread

I think there might be an error on this line
https://github.com/datahub-project/datahub/blob/514c2fb157e14608eace62fc6fb632ccfb7a7157/docker/quickstart/docker-compose-without-neo4j.quickstart.yml#L109|https://github.com/datahub-project/datahub/blob/514c2fb157e14608eace62fc6fb632ccfb[…]7/docker/quickstart/docker-compose-without-neo4j.quickstart.yml

While upgrading from 0.10.3 to 0.12.0, I had to change this to DATAHUB_GMS_PORT for it to work in my setup. It’s trying to health check the docker hostname on the externally mapped port otherwise.

test: curl -sS --fail <http://datahub-gms>:${DATAHUB_MAPPED_GMS_PORT:-8080}/health

test: curl -sS --fail <http://datahub-gms>:${DATAHUB_GMS_PORT:-8080}/health

Hey there! :wave: Make sure your message includes the following information if relevant, so we can help more effectively!

  1. Which DataHub version are you using? (e.g. 0.12.0)
  2. Please post any relevant error logs on the thread!

Thanks for sharing, Chris! <@U03MF8MU5P0> any thoughts here?

Thanks for sharing, I’ll update the script

Actually this issue is more than just neo4j, technically the healthchecks should be using the non-mapped port. Running some tests locally but if it looks ok, I’ll update all of them.

Yup, that makes sense, I just noticed in this one since that’s the one I was working from as a reference.